Conversation
dosubot
bot
added
the
size:L
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
dosubot
bot
added
bug
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
💤 Files with no reviewable changes (2)
🚧 Files skipped from review as they are similar to previous changes (1)
WalkthroughThe Support tab and its component file were removed: imports, rendering, and test mock deleted. Support-related navigation items and the sidebar "settings" section were removed. Support was dropped from HOSTED_SIDEBAR_ALLOWED_TABS. Help links (documentation, Discord, bug report, GitHub) were added as a Help & support dropdown in the auth upper area. SidebarUser UI was simplified by removing the email display and per-organization Settings button. 📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment Tip You can get early access to new features in CodeRabbit.Enable the |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@mcpjam-inspector/client/src/components/sidebar/sidebar-user.tsx`:
- Around line 128-145: The current JSX nests a native <button> for settings
inside SidebarMenuButton (which renders a button by default), causing invalid
<button><button>…</button></button> nesting and broken interactions; fix it by
making the settings control a sibling of SidebarMenuButton (move the
onSettingsClick block out of SidebarMenuButton’s children) or switch
SidebarMenuButton to render asChild so it doesn’t output a native button (use
asChild on SidebarMenuButton and pass the wrapper element), ensure the Settings
button keeps its event handlers (onClick/onPointerDown) and that the
ChevronsUpDown element (with className logic using onSettingsClick) remains
positioned correctly after the change.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 9143f4bf-2809-486d-9b92-3d5f29eeb9ef
📒 Files selected for processing (7)
mcpjam-inspector/client/src/App.tsxmcpjam-inspector/client/src/__tests__/App.hosted-oauth.test.tsxmcpjam-inspector/client/src/components/SupportTab.tsxmcpjam-inspector/client/src/components/auth/auth-upper-area.tsxmcpjam-inspector/client/src/components/mcp-sidebar.tsxmcpjam-inspector/client/src/components/sidebar/sidebar-user.tsxmcpjam-inspector/client/src/lib/hosted-tab-policy.ts
💤 Files with no reviewable changes (4)
- mcpjam-inspector/client/src/tests/App.hosted-oauth.test.tsx
- mcpjam-inspector/client/src/components/SupportTab.tsx
- mcpjam-inspector/client/src/lib/hosted-tab-policy.ts
- mcpjam-inspector/client/src/App.tsx
mcpjam-inspector/client/src/components/sidebar/sidebar-user.tsx
Outdated
Show resolved
Hide resolved
2 participants
No description provided.